Repository navigation
E07: Remove the v1 Analyzer logger - #250
Merged
Merged
Conversation
…writer Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…cs, CHANGELOG, upgrade guide Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by the repository owner: remove the v1 Analyzer logger, make v2 the only Analyzer, and remove the v1 bindings and docs. This is a breaking change for code that uses
ioh.logger.old,Experiment(old_logger=...)or namesanalyzer::v1/v2in C++. The CHANGELOG (### Removed) and the upgrade guide list each removed item and what to use instead. The Analyzer output is unchanged: the byte-for-byte golden tests pass.Work package E07: Remove the v1 Analyzer logger
Branch: wp/E07-remove-analyzer-v1
Status: ready for review
Done
step 1/3: folded analyzer::v1 and v2 into one analyzer::Analyzer, removed the .info writer and its C++ tests; 118 C++ tests pass (Debug).
step 2/3: removed ioh.logger.old, Experiment(old_logger=), stubs, tests, tutorial, example README.
step 3/3: CHANGELOG ### Removed and upgrade guide sections. Python module built in .venv; all Python tests pass in a
copy outside the tree (test_golden.py and test_logger.py included). The one error
test_array_layout.py:: tester_inc_one_transformis pytest collecting a helper function, unrelated.Next step
None. Controller: push once E05 is merged and open the draft PR.
Decisions
analyzer::v2::Analyzeralias: the class isioh::logger::analyzer::Analyzer,ioh::logger::Analyzeris an alias to it.use_old_data_formatconstructor argument with v1.full_precisionand "precision" JSON key.Open questions / Blocked
Work package from the IOHanalyzer rebuild plan (
plan/in IOHprofiler/ioh-web). Review and merge are done by a person.🤖 Generated with Claude Code