Skip to content

Added option for MPO-MPS zipup - #97

Merged
mtfishman merged 5 commits into
ITensor:mainfrom
corbett5:feature/corbett/mpo-mps-zipup
Mar 23, 2026
Merged

mtfishman merged 5 commits into
ITensor:mainfrom
corbett5:feature/corbett/mpo-mps-zipup

Conversation

@corbett5

Copy link
Copy Markdown
Contributor

@corbett5

Copy link
Copy Markdown
Contributor Author

Sorry for the delay to move it here.

@corbett5

Copy link
Copy Markdown
Contributor Author

@mtfishman If I resolve the merge conflicts can this be merged?

@mtfishman

Copy link
Copy Markdown
Member

@mtfishman If I resolve the merge conflicts can this be merged?

Sure, though I have some review comments. Go ahead and fix the merge conflicts and then I'll do a review.

@github-actions

github-actions Bot commented Dec 8, 2025 •

Copy link
Copy Markdown
Contributor

Your PR no longer requires formatting changes. Thank you for your contribution!

@corbett5

corbett5 commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

@mtfishman up to date and the tests are passing locally so I think it's good for your review.

@codecov

codecov Bot commented Dec 9, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (990422b) to head (7ad7173).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   90.31%   90.33%   +0.01%     
==========================================
  Files          54       54              
  Lines        3605     3610       +5     
==========================================
+ Hits         3256     3261       +5     
  Misses        349      349              
Flag Coverage Δ
docs 17.98% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdityaD16

Copy link
Copy Markdown

Hi @corbett5 @mtfishman, is there any update on when this PR might be merged?

@mtfishman

Copy link
Copy Markdown
Member

Hi @corbett5 @mtfishman, is there any update on when this PR might be merged?

Sorry this slipped through the cracks, I'll make a few tweaks to this and then merge it (today or tomorrow).

mtfishman added a commit that referenced this pull request Mar 23, 2026
@github-actions

github-actions Bot commented Mar 23, 2026 •

Copy link
Copy Markdown
Contributor

Your PR no longer requires formatting changes. Thank you for your contribution!

@mtfishman

Copy link
Copy Markdown
Member

Sorry for the slow response on this @corbett5, thanks for the PR. I'll merge once tests finish running.

@mtfishman
mtfishman enabled auto-merge (squash) March 23, 2026 20:15
@corbett5

Copy link
Copy Markdown
Contributor Author

@mtfishman, no worries. Thanks for finishing it off.

@mtfishman
mtfishman merged commit 267c7ea into ITensor:main Mar 23, 2026
15 checks passed
@corbett5
corbett5 deleted the feature/corbett/mpo-mps-zipup branch March 23, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants