Skip to content

Validate NormNetwork bra names at construction, add layer accessors, interface improvements. - #206

Open
jack-dunham wants to merge 10 commits into
mainfrom
jd/normnetwork-interface
Open

jack-dunham wants to merge 10 commits into
mainfrom
jd/normnetwork-interface

Conversation

@jack-dunham

@jack-dunham jack-dunham commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor
  • KetView and indmap are removed. Use ketnetwork and branetwork to get the layers.
  • Default bra names come from derivedname, so they are the same every time. Every link needs a bra name, and the name map is checked on construction.
  • Adds inds(tn, v), axes(tn, v), names(tn, v) and eachlinkname(tn).
  • dimnamevertices now returns Indices.

Breaking, so the version goes to 0.12.0.

jack-dunham and others added 2 commits October 30, 2026 13:51
Default bra names are derived with `derivedname`, and every link name must have one.
`KetView` and `indmap` are removed; `ketnetwork` and `branetwork` return the layers.
Adds `inds`, `axes` and `names` of a vertex and `linknames(tn)` to the network interface.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (97511f5) to head (9cb685e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   88.90%   91.89%   +2.99%     
==========================================
  Files          17       17              
  Lines         730      753      +23     
==========================================
+ Hits          649      692      +43     
+ Misses         81       61      -20     
Flag Coverage Δ
docs 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-dunham
jack-dunham added this pull request to stack #208 October 30, 2026 18:11
…sing correlator

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread src/normnetwork.jl Resolved
Comment thread src/normnetworkview.jl Resolved
Comment thread src/abstracttensornetwork.jl Resolved
Comment thread test/test_tensornetwork.jl Resolved
jack-dunham and others added 7 commits November 2, 2026 11:18
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ing as optional arg

Drop some `NormNetwork` constructors.
…d `siteaxes`

`dimnamevertices` and the `dimname_vertices` table of `ITensorNetwork` now hold
`Indices` instead of `Set`, so the vertex order is insertion order. `linkaxes` and
`siteaxes` return tuples to match `axes`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Calls this via a function `derive_braname`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants