Repository navigation
Validate NormNetwork bra names at construction, add layer accessors, interface improvements. - #206
Open
jack-dunham wants to merge 10 commits into
Open
jack-dunham wants to merge 10 commits into
jack-dunham wants to merge 10 commits into
Conversation
Default bra names are derived with `derivedname`, and every link name must have one. `KetView` and `indmap` are removed; `ketnetwork` and `branetwork` return the layers. Adds `inds`, `axes` and `names` of a vertex and `linknames(tn)` to the network interface. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 88.90% 91.89% +2.99%
==========================================
Files 17 17
Lines 730 753 +23
==========================================
+ Hits 649 692 +43
+ Misses 81 61 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…sing correlator Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mtfishman
reviewed
Nov 2, 2026
mtfishman
reviewed
Nov 2, 2026
mtfishman
reviewed
Nov 2, 2026
mtfishman
reviewed
Nov 2, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ing as optional arg Drop some `NormNetwork` constructors.
…d `siteaxes` `dimnamevertices` and the `dimname_vertices` table of `ITensorNetwork` now hold `Indices` instead of `Set`, so the vertex order is insertion order. `linkaxes` and `siteaxes` return tuples to match `axes`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Calls this via a function `derive_braname`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KetViewandindmapare removed. Useketnetworkandbranetworkto get the layers.derivedname, so they are the same every time. Every link needs a bra name, and the name map is checked on construction.inds(tn, v),axes(tn, v),names(tn, v)andeachlinkname(tn).dimnameverticesnow returnsIndices.Breaking, so the version goes to 0.12.0.