Repository navigation
Conversation
Signed-off-by: zengchuang <zengchuang3@huawei.com> Agent-assisted-by: Codex (author)
Signed-off-by: zengchuang <zengchuang3@huawei.com> Agent-assisted-by: Codex (author)
amy-why-3459
left a comment
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 6c7e237 and head 42608e2.
Verified the release-tag git_describe_command is applied before tag_regex, so a nearer annotated evidence, prerelease, or extra-component tag no longer blocks setuptools-scm version discovery. test_wheel_version_discovery_ignores_nearer_nonrelease_tags reads the live pyproject command and covers those three cases.
The installed resource assertion update 927 → 928 is required for this tree: this PR adds no resource file, so the extra packaged file is already on main, and installed-package (3.10/3.11) passed on this head.
Required checks on this head passed: full-check 3.10/3.11, installed-package 3.10/3.11, host-compatibility Windows/macOS, dashboard-browser, pr-references, and declarations. Accuracy and performance comparison evidence is not applicable. No architectural or redundant-change concerns; this is a scoped slice of #371 step 5, with native plugin install/upgrade work correctly left for later.
|
@Dong1017 @david6666666 麻烦检视 #470 的当前提交 |
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 6c7e237935a22cc5e90e954d4f397376e753e7d8 and head 42608e243f279e0197cea837c115160f6f51435d.
Verified setuptools_scm git_describe_command selects release tags (vX.Y.Z) and excludes evidence/prerelease/extra-component tags; test_wheel_version_discovery_ignores_nearer_nonrelease_tags covers exact release + nearer non-release tags; installed resource count 928 matches #382 Ascend source note with per-file digests retained. Ready CI green; MERGEABLE.
Standing steward review delegation while hosted Dong-bot is on usage_limit.
Governing issue and delivery slice
Refs #371, step 5.
A full checkout of current main selected an annotated evidence tag for
setuptools-scmand failed before building the sdist. Apply the release-tag filter when Git selects a tag, then use the existing version regex. The configuration retains compatibility with the currentsetuptools-scm>=8build requirement.After the tag filter restored the build, the installed checker found 928 resources. The sole added resource is the Ascend model adaptation source note from #382. Update the exact inventory assertion to 928. The checker still compares source and installed resource bytes.
Verification
41 release tests passed, including the case with an exact release tag and nearer evidence and non-release tags. Ruff and the staged diff check passed.
On Windows, a clean build from the tagged Git checkout produced the sdist and a wheel built from that sdist. A fresh environment outside the checkout installed
0.2.3.dev13+g42608e243. The installed checker verified all 928 resources.inferrsiandpython -m inferrsiagreed on version and the benchmark list. The canonical Apps Python entry points imported successfully, and the two paths retired by #461 were absent. The sdist was extracted under a short local path to stay within the Windows build path limit.48 local Windows checks passed across the eight ready-lane host cases, WorkSwarm manifest/launcher, DSH bundle outside the checkout, and the frozen legacy run and split tests. A DSH 0.2.1-rc.2 isolated profile passed native install, manifest identity, installed launcher and removal. The WorkSwarm v0.2.7 native backend passed two isolated lifecycle cycles, including selection, the rendered locator handoff, exact fixed reads and stale-revision rejection. Codex desktop archive import and cross-version host upgrades remain part of #371 step 5.