Repository navigation
Conversation
…lution The schema registries are filled by a @PostConstruct callback. With Spring Boot 4 (Spring 7), the javax.annotation.PostConstruct they used was silently ignored, leaving the registries empty: x-onyxia.overwriteSchemaWith was no longer resolved in values.schema.json and the default profile schema was not loaded. #701 switched to jakarta.annotation.PostConstruct; these tests go through the Spring context so that such a regression is caught. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After the Spring Boot 4 migration (#636),
JsonSchemaRegistryServiceandJsonSchemaProfileRegistryServicestill usedjavax.annotation.PostConstruct. Spring 7 no longer honours thejavaxannotation, so the callbacks that fill the registries never ran, and nothing logged an error:x-onyxia.overwriteSchemaWithin charts'values.schema.json(ide/resources.json,nodeSelector.json,ide/ingress.json,ide/s3.json, …) was returned unresolved;#701 fixed it by switching to
jakarta.annotation.PostConstruct, but no test covered it.What
New
JsonSchemaResolutionServiceTest, which goes through the Spring context so the lifecycle callback is exercised:overwriteSchemaWithis replaced by the registry schema;#/definitions/...$refs are resolved;profile.schema.directory.Checked
mvn verify: 71 tests pass, spotless OK.@PostConstructremoved (same effect as Spring 7 ignoring thejavaxannotation), 3 of the 5 tests fail: empty registry, unresolvedoverwriteSchemaWith,nullprofile schema.No production code change.
🤖 Generated with Claude Code