Repository navigation
Conversation
- write_hrc(): remove a \cr right after an itemize list in the fill_na
parameter, which broke the PDF manual ("There's no line here to end").
- tab_multi_manager() example: write the hrc file to tempdir() instead of
"hrc/" in the working directory (left an 'hrc' folder in the check dir).
- auto_metadata_fr vignette: use the French title as VignetteIndexEntry,
which duplicated the English vignette's entry; re-render its HTML, which
was also out of date with the .Rmd.
- DESCRIPTION: drop "StagedInstall: no" (non-staged installation NOTE);
staged installation works and passes R's install-path checks.
devtools::check(manual = TRUE): 0 errors, 0 warnings, 0 notes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devtools::check(manual = TRUE)onmastergave a warning (LaTeX error while building the PDF manual) and 3 notes. With this PR it gives 0 errors, 0 warnings, 0 notes.Changes
! LaTeX Error: There's no line here to end.): inwrite_hrc(), thefill_naparameter had a\crdirectly after an\itemize{}list, which becomes a\\with no line to end in LaTeX. Removed it (the end of the list already starts a new line). This was the only occurrence of that pattern.hrcin the check directory: thetab_multi_manager()example (the part outside\dontrun{}) wrotehrc/activityinto the working directory. It now writes tofile.path(tempdir(), "activity"); the rest of the example uses the returned path, so nothing else changes.auto_metadata_frused the English%\VignetteIndexEntry. It now uses its French title, "Analyse automatique des métadonnées", like the other French vignettes. Its HTML is re-rendered; note that the committedauto_metadata_fr.htmlwas out of date with its.Rmd, so the rendered diff also picks up content that was already in the source (e.g. the "Equations entre indicateurs" section).StagedInstall: nofromDESCRIPTION. With staged installation, the package installs and loads correctly, including R's checks that it loads from the final location and keeps no record of the temporary installation path.Question about
StagedInstall: noStagedInstall: nowas added in c9a89a5 ("check cran", January 2024) without an explanation in the commit. Was there a specific reason for it, for example staged installs failing on INSEE workstations (network-mounted libraries, antivirus locking files during the move to the final location)? If so, I'm happy to restore it. It works fine without it on my setup (Windows 11, R with a local library), but I don't want to reintroduce a problem you've already hit.Note
This overlaps with files touched by #69 (documentation cleanup), notably
R/hrc.R,R/multitable.RandDESCRIPTION, so whichever is merged second may need a rebase. #69 does not fix these check issues. The changes here are one-line edits, so they should be easy to rebase.🤖 Generated with Claude Code