Repository navigation
Conversation
jdotc1
marked this pull request as ready for review
October 23, 2026 04:28
Contributor
[Medium impact] The PR appears safe to merge within its stated scope.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate Bruker geometry arrays before indexing them. Addresses S1 of #6813; other items remain open.
Scope and risk
This covers S1 and a dimension prerequisite, not the whole public security issue. Signed frame counts, frame-group arithmetic and zero/nonfinite physical extents remain outside the patch. Native parser/geometry regressions are mandatory.
Validation
130 isolated accessor cases compile and pass with GCC, AddressSanitizer and UndefinedBehaviorSanitizer. The isolated harness itself is not an ITK parser test.
Native ITK validation is now available for current head
70e68533ea2dbf43da546f3ccfdcbf49c31b33d9. The Linux ARM64 job compiled with zero compiler errors and warnings and passed all 4,722 configured tests. All sixBruker2dseqImageIOcases passed, including the short-array and unsupported-dimension regressions, the ParaVision 360 dataset case, oversized RLE expansion, unexpected scaling-array length, and slice-step handling.The current-head platform matrix has completed: 18 checks passed, with no pending or failing reported checks. The only skipped job is
publish-doxygen-tagfile. Completed checks include Windows C++, macOS and Ubuntu Pixi C++, x86_64 Rosetta, ARM Python, Azure Linux and macOS Python, pre-commit, Doxygen, performance and documentation. The native Linux ARM64 test results above are reused; no tests were repeated for this status update.Ready for maintainer review. The scope limits above still apply; maintainer review is needed before merging.