Skip to content

COMP: Remove the retired Cloudflare ExternalData mirror - #6993

Merged
hjmjohnson merged 1 commit into
InsightSoftwareConsortium:mainfrom
jdotc1:fix/jdotc1-pr-08-itk-retired-mirror-20261023
Oct 23, 2026
Merged

hjmjohnson merged 1 commit into
InsightSoftwareConsortium:mainfrom
jdotc1:fix/jdotc1-pr-08-itk-retired-mirror-20261023

Conversation

@jdotc1

@jdotc1 jdotc1 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Remove the retired Cloudflare entry from the default ExternalData mirrors. Closes #6754.

Validation

The actual ITK configuration was executed with CMake 4.4.4 before and after the change. Four paired scenarios cover downloads enabled/forbidden and caller-supplied templates. The comparison preserves other mirrors and their ordering, object stores, hash aliases, series settings, and timeout. An unpatched control fails as expected.

Utilities/SetupForDevelopment.sh completed, and every applicable pinned pre-commit hook passed for CMake/ITKExternalData.cmake, including gersemi and the local development-setup checks. git diff --check passed. Current-head hosted checks completed with 15 successes and one skipped publishing job; all three commit statuses succeeded.

The two-line configuration cleanup adds no upstream unit test. No live mirror check or local native ITK rebuild was performed.

@github-actions github-actions Bot added type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Oct 23, 2026
@jdotc1
jdotc1 marked this pull request as ready for review October 23, 2026 12:36
@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The change reaches ITK's default test-data download choices.

The change appears safe to merge, with a small, non-blocking update needed in the download guide.

Findings

  1. P2 Guide still lists retired gateway ▶

Summary

Removes the retired Cloudflare gateway from the default ExternalData mirrors.

  • ITK's default test-data lookup no longer includes the Cloudflare gateway.

Reviews (1) · Last reviewed commit: "COMP: Remove the retired Cloudflare Exte..." · Reviewed by Greptile

Comment thread CMake/ITKExternalData.cmake
The remaining mirrors already provide redundancy.

Closes InsightSoftwareConsortium#6754.
@hjmjohnson
hjmjohnson force-pushed the fix/jdotc1-pr-08-itk-retired-mirror-20261023 branch from 0b60449 to 687accc Compare October 23, 2026 14:57
@github-actions github-actions Bot added the area:Documentation Issues affecting the Documentation module label Oct 23, 2026

@dzenanz dzenanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a glance.

@hjmjohnson
hjmjohnson merged commit 64587e1 into InsightSoftwareConsortium:main Oct 23, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Documentation Issues affecting the Documentation module type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

COMP: Remove the retired cloudflare-ipfs.com ExternalData mirror

3 participants