Repository navigation
Conversation
Allow singleton slices to retain smoothing along their longer axes. Recursive gradient filtering remains a separate follow-up. Closes InsightSoftwareConsortium#6997
Author
|
The Linux Python failure looks unrelated to this change: Gaussian smoothing passes, and the only failure among 185 tests is the median filter’s type-hint check ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This lets
SmoothingRecursiveGaussianImageFilterskip axes shorter than four pixels while smoothing the remaining axes, including singleton slices used in registration. Closes #6997.Scope and local testing
Local checks on Linux:
SmoothingRecursiveGaussianImageFilter#6997 unchanged. Bothsigma=1.0andsigma=0.0recovered the expected 4-pixel X translation.PR Checklist
PR Checklist
No public API additions or new wrapped classes. The class documentation describes the short-axis behavior; both new test files have the standard license header. No separate examples contribution is needed for this enhancement.
AI assistance
AI assistance contributed to diagnosis, implementation, and regression tests. Focused C++ and Python checks passed locally.