Repository navigation
Drop registry-url from typescript-release's setup-node - #180
Merged
Merged
Conversation
setup-node v7 no longer exports a placeholder NODE_AUTH_TOKEN, so the .npmrc it writes for registry-url leaves ${NODE_AUTH_TOKEN} unresolved and yarn v1 fails before install. npm Trusted Publishing uses the default registry and needs no .npmrc.
|
Merging this PR will move these workflow tags: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6d15d7c |
coltfred
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/setup-node@v7no longer exports a placeholderNODE_AUTH_TOKENwhen the caller doesn't provide one. Withregistry-urlset, it still writes an.npmrcwhose_authTokenreferences${NODE_AUTH_TOKEN}, and yarn v1 aborts on the unresolved variable before installing anything:This broke the ironnode 1.3.0 publish (https://github.com/IronCoreLabs/ironnode/actions/runs/38970496957/job/117207389973) and will break the next release of recrypt-wasm-binding and recrypt-node-binding, the other callers.
This removes
registry-url. Trusted Publishing doesn't read.npmrc: npm 11's OIDC exchange uses the configured registry, which defaults tohttps://registry.npmjs.org/.Checked locally with yarn 1.22.22 against ironnode's
package.jsonandyarn.lock:yarn install --frozen-lockfilefails with the CI stack trace whenNPM_CONFIG_USERCONFIGpoints at an.npmrccontaining${NODE_AUTH_TOKEN}and the variable is unset, and succeeds with no.npmrc. With no.npmrc,npm config get registryreturnshttps://registry.npmjs.org/. The OIDC publish itself is exercised only by the next release run.Non-breaking:
tag-versionstaysv1, sotypescript-release-v1.0.0moves on merge.