Skip to content

test(protocols): test_mh_unit's _drop_tracebacklimit cleanup has been dead since #362 #1924

Closed

Description

@JarryShaw

tests/protocols/internet/test_mh_unit.py:1667-1675 registers a cleanup that deletes sys.tracebacklimit because "the loud _missing_ ... sets this process-wide". Since #362, no pcapkit code sets sys.tracebacklimit: the BaseError docstring's versionchanged:: 1.5.0 says so, and a grep of pcapkit/ finds no assignment. The cleanup therefore does nothing useful. Because it deletes the attribute whenever it exists, it would also remove a value the test runner had set.

#1915 already corrects the comment but leaves the code.

Fix: once #1915 lands, drop the cleanup, plus import sys if nothing else in the test uses it.

Found in the #1103 round-4 sweep.

Blocked until #1915 merges, since that PR rewrites the same comment.

Activity

  1. added
    testPull requests that add or correct tests (test: subject prefix)
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 19, 2026
  2. moved this to Blocked in PyPCAPKiton Oct 19, 2026
  3. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 19, 2026
  4. moved this from Blocked to WIP in PyPCAPKiton Oct 19, 2026
  5. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testPull requests that add or correct tests (test: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions