chore(corekit): spell the import-outside-toplevel pragma correctly (#1923)

[JarryShaw]

• Searched for similar pull requests

• Followed the coding style (make pylint, make mypy, make isort)

• make test passes, and a test case covers the change

• Added a changelog entry — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

• chore — anything else

Corrects the misspelt import-outside-top-level pylint pragmas in corekit/fields/collections.py and misc.py. pylint ignored them with W0012 and kept reporting C0415. Only comments change; the AST is identical.

The new tests/project/test_pylint_pragma_names_1923_unit.py checks every pragma name in pcapkit/ against a pinned list. Where pylint can be imported, it also checks each name against pylint's message store. No test extra installs pylint, so in CI only the pinned list runs. The test fails on main.

Closes #1923

[JarryShaw]

GOOD TO GO at 15442a362. A Sonnet cross-review reverted both source files: pylint then reported W0012 at all five pragma sites and still flagged C0415, and with the fix both disappear. Run with the Makefile plugins over all of pcapkit/, it finds no other unknown pragma name. The AST is unchanged. The new test reads only tokenize comments and fails on main, and tests/project passes. CI runs only the pinned-list check, because only lint.yml installs pylint and it runs no tests.

[JarryShaw]

NEEDS CHANGES at 15442a362. The Python 3.12 and 3.13 legs fail on tests/test_tier_guard.py::DependencyGateCoverageTests::test_every_gated_flag_is_classified. The new test gates on a local HAS_PYLINT at test_pylint_pragma_names_1923_unit.py:172, which tests._dependency_gates cannot resolve. Fix: define the flag in tests/_dependency_gates.py in the shape the guard reads, or list it in NON_DISTRIBUTION_FLAGS. The review missed this because it did not run the tier guard.

[JarryShaw]

GOOD TO GO at 0f1f4ea1c. HAS_PYLINT now uses the find_spec shape the scanner reads. It is declared in tests/_dependency_gates.py next to HAS_MYPY, with dark={'test','gate'}, which matches the guard's derived job set exactly. A Sonnet re-review ran tests/test_tier_guard.py with pylint importable and with it blocked, and both runs pass. With pylint blocked, the lookup skips visibly. The test still fails on main's source files. The exclusion's reason checks out: only lint.yml installs pylint, and it runs with W0012 enabled.

[github-actions]

Coverage: 90.07% (unit tier, Python 3.15, 0f1f4ea1c, Unit Tests run success)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	2	20	2	96.77%
pcapkit/const	19595	881	2618	867	92.11%
pcapkit/corekit	2504	70	792	36	96.54%
pcapkit/dumpkit	276	3	100	3	98.40%
pcapkit/foundation	2916	164	1016	34	93.59%
pcapkit/interface	138	7	52	5	93.68%
pcapkit/protocols	17411	224	4580	189	98.10%
pcapkit/toolkit	872	177	298	8	77.18%
pcapkit/utilities	522	2	158	4	99.12%
pcapkit/vendor	4431	2341	1018	156	43.64%

Per-file detail: the coverage-html artifact of this run.