Repository navigation
ci(timing): budget the job reads and publish a cut-short report (#1930) - #1931
Merged
Merged
Conversation
- util/ci_timing.py: read the listings, workflow files and JUnit artifacts first and the job reads last, interleaved so every prefix spans each sample; stop them at --budget-minutes (default 30) or --max-calls and still write the report, with a note and a warning annotation - util/ci_timing.py: print a progress line per step to stderr, so a run killed by a cap shows how far it got; skip or abandon the runner-pool measurement once the budget is spent - ci-timing.yml: give the report step a 35-minute cap and the job a 40-minute one, above the measured 16.6-minute full run; add the summary and upload the report on always() - docstring, workflow comments and workflows.rst carry the measured calls and where the time goes - tests: the read order, both budgets writing a report, progress on stderr, and the nested caps Closes #1930
Owner
Author
|
GOOD TO GO at |
Contributor
|
Coverage: 90.07% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeAdded a changelog entry — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657
ci— workflows or build toolingA full local
--days 7run ofutil/ci_timing.pytook 16.6 min over 677 API calls, with no retries or rate limiting. That is longer than the job's 15-minute cap. Of that time, 908 s went on job reads, and Unit Tests' 301 reads alone took 734 s, at 2.4 s each, one at a time.--budget-minutes 30.always().Tests cover the read order, both budgets still writing a report, the progress output and the nested caps. They fail on
main.Closes #1930