Skip to content

ci(release): count osx-arm64 in the Anaconda completeness check (#1922) - #1932

Merged
JarryShaw merged 1 commit into
mainfrom
ci/1922-count-osx-arm64
Oct 19, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
ci/1922-count-osx-arm64

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

version_check's Anaconda completeness check only counted linux-64 and osx-64. A release whose osx-arm64 upload had failed still read PCAPKIT_CONDA_COMPLETE=true, so the conda gate skipped it. Per the ruling on #1922, osx-arm64 now counts too.

A single PCAPKIT_CONDA_SUBDIRS list now sets both the expected count and which platforms are counted. A new test pins that list to the conda job's os matrix and its target_platform mapping. It also runs the step against a listing with osx-arm64 missing, which fails on main. releasing.rst is updated to match. 1.5.0b13 already has all three platforms on Anaconda.

Closes #1922

- version_check's Anaconda check counted linux-64 and osx-64 only, so a
  release whose osx-arm64 upload failed still read complete and the conda
  gate skipped it; it now reads one PCAPKIT_CONDA_SUBDIRS list of every
  platform the conda legs publish, which sets both the expected count and
  the counted set
- releasing.rst describes the check as it now counts
- a new test pins that list to the conda job's matrix and runs the step
  against a fake listing missing osx-arm64; the existing 1660 and 1634
  completeness fixtures include osx-arm64

Closes #1922
@JarryShaw JarryShaw added ci Pull requests that change CI or workflow configuration (ci: subject prefix) review: running A cross-review is in flight against the current head - no verdict yet labels Oct 19, 2026
@JarryShaw JarryShaw moved this to In review in PyPCAPKit Oct 19, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

GOOD TO GO at 00799a72a. A Sonnet cross-review checked the conda matrix: it has no exclude and one Python list for every leg, and the case arms map to exactly linux-64, osx-64 and osx-arm64. So subdirs times builds is the right count. The exported list reaches the python3 - pipe under set -e, and the gate and stranded-release check only read the boolean. Restoring main's workflow fails three of the new tests, and so does dropping a matrix leg. The PR merges cleanly with #1926. One thing to expect: a release published earlier with only two subdirs will now read incomplete, and the next run uploads just the missing osx-arm64 leg.

@JarryShaw JarryShaw added review: good-to-go Cross-review at the current head says ready; CI state is separate and removed review: running A cross-review is in flight against the current head - no verdict yet labels Oct 19, 2026
@JarryShaw
JarryShaw merged commit cf315a8 into main Oct 19, 2026
56 checks passed
@JarryShaw
JarryShaw deleted the ci/1922-count-osx-arm64 branch October 19, 2026 15:02
@github-project-automation github-project-automation Bot moved this from In review to Done in PyPCAPKit Oct 19, 2026
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pull requests that change CI or workflow configuration (ci: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

ci(release): the Anaconda completeness check does not count osx-arm64

1 participant