Repository navigation
ci(release): count osx-arm64 in the Anaconda completeness check (#1922) - #1932
Merged
Merged
Conversation
- version_check's Anaconda check counted linux-64 and osx-64 only, so a release whose osx-arm64 upload failed still read complete and the conda gate skipped it; it now reads one PCAPKIT_CONDA_SUBDIRS list of every platform the conda legs publish, which sets both the expected count and the counted set - releasing.rst describes the check as it now counts - a new test pins that list to the conda job's matrix and runs the step against a fake listing missing osx-arm64; the existing 1660 and 1634 completeness fixtures include osx-arm64 Closes #1922
Owner
Author
|
GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeAdded a changelog entry — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657
ci— workflows or build toolingversion_check's Anaconda completeness check only counted linux-64 and osx-64. A release whose osx-arm64 upload had failed still readPCAPKIT_CONDA_COMPLETE=true, so thecondagate skipped it. Per the ruling on #1922, osx-arm64 now counts too.A single
PCAPKIT_CONDA_SUBDIRSlist now sets both the expected count and which platforms are counted. A new test pins that list to thecondajob'sosmatrix and itstarget_platformmapping. It also runs the step against a listing with osx-arm64 missing, which fails onmain.releasing.rstis updated to match. 1.5.0b13 already has all three platforms on Anaconda.Closes #1922