Repository navigation
docs: date the __excluded__ and Raw directives to the release that shipped them (#1933) - #1934
Merged
Merged
Conversation
…ipped them (#1933) - Info: iteration skipping __excluded__ names first shipped in 1.3.1.post8, not 1.3.3. - data.misc.raw.Raw: packet left Raw's fields, and the constructor's signature, in 1.3.1.post8, when the base Protocol data class took it over, not in 1.3.3. Docstrings only; the AST is identical with docstrings blanked. Closes #1933
Owner
Author
|
GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeAdded a changelog entry — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657
docs— documentation onlyTwo
versionchanged:: 1.3.3directives describe changes that first shipped in1.3.1.post8:Info.__iter__gained its__excluded__skip inab8a21c7a.RawbecameRaw(Protocol)with nopacketfield ina7d5df73c.v1.3.1.post7has neither change, and the files are unchanged frompost8through1.3.3. Under the ruling on #1911, a post-release change is marked with its own post-release, so both directives now say1.3.1.post8. The edits are docstring-only, and the AST is identical.docs/source/changelog/1.3.3.rststill lists both changes under 1.3.3; changelog edits stay with #657.Closes #1933