feat(baoyu-image-gen): add Atlas Cloud provider - #190
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed21e50b0c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (args.responseFormat === "url") { | ||
| return new Uint8Array(Buffer.from(outputUrl, "utf-8")); |
There was a problem hiding this comment.
When --response-format url is used with an extensionless output path, this branch returns UTF-8 URL bytes, but the Atlas provider does not export getDefaultOutputExtension, so prepareSingleTask/prepareBatchTasks normalize the path with the default .png. The command succeeds while writing a text URL into out.png, which downstream image consumers see as a corrupt image; mirror the Agnes provider by defaulting URL mode to .txt.
Useful? React with 👍 / 👎.
| if (hasReplicate) return "replicate"; | ||
| if (hasSeedream) return "seedream"; | ||
| if (hasMinimax) return "minimax"; | ||
| if (hasAtlascloud) return "atlascloud"; |
There was a problem hiding this comment.
With only ATLASCLOUD_API_KEY configured and a remote reference such as --ref https://.../ref.png, this auto-selection path is intended to choose Atlas Cloud, but both prepareSingleTask and prepareBatchTasks validate references before calling detectProvider and only allow remote URLs when args.provider is already a remote-capable provider. Since args.provider is null in auto mode, the URL is resolved as a local path and the Atlas branch is never reached; auto-detected Atlas edit workflows with remote refs fail unless users redundantly pass --provider atlascloud.
Useful? React with 👍 / 👎.
|
Addressed the automated review feedback in |
1 participant
Summary
atlascloudprovider forbaoyu-image-genwith Nano Banana 2 text-to-image and edit flows.Testing
node --import tsx --test $(rg --files skills/baoyu-image-gen/scripts | rg '\.test\.ts$' | sort)--provider atlascloud --quality normal --ar 1:1No root README changes.