Repository navigation
Move macOS CI back to github actions - #578
christiangnrd wants to merge 1 commit into
Conversation
efa4ed8 to
87bdc65
Compare
|
@maleadt this greatly increases the runtime of the macos tests, but I think it’s worth it to free up the metal runners on buildkite. Do we want to keep one 1.10 run or should we stick to the 1.13 runs, and one of the 1.13 runs took 2h5 minutes, do you think a 2.5h timeout is reasonable? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 88.80% 90.11% +1.31%
==========================================
Files 18 18
Lines 1751 1751
==========================================
+ Hits 1555 1578 +23
+ Misses 196 173 -23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Still broken on 1.10? https://github.com/JuliaGPU/OpenCL.jl/actions/runs/39816117372?pr=578 Once the job times out, I'll make the buildkite job 1.10 only and move over the 1.13 jobs. We could probably just remove the 1.10 job since if we follow the pattern we only test other julia versions on x64 linux |
1bd6dba to
d071ec4
Compare
This frees the Buildkite metal runners for the packages that need a GPU. GitHub's macOS runners are about twice as slow, so their jobs get a 150-minute timeout. Julia 1.10 stays on Buildkite: on GitHub Actions it hangs, because its libuv can miss the exit of a child process on macOS (JuliaLang/libuv#50). Co-authored-by: Tim Besard <tim.besard@gmail.com>
See JuliaGPU/GPUCompiler.jl#1042
Turns out we probably wouldn't even be testing macOS 1.10 anymore here anyways, so I added the macos and julia 1.10 jobs to test out. We should keep at most 1 of them before merging