Repository navigation
Conversation
Builds that set LLC_TRIPLE to the unnormalized x86_64-w64-mingw32 rather than LLVM's normalized x86_64-w64-windows-gnu missed the --mingw wrapper flag, leaving vector arguments of the SPIR wrappers mismatched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pocl#2381 passes the SPIR wrapper generator
--mingwwhenLLC_TRIPLEmatches-windows-gnu, LLVM's normalized spelling. Builds that setLLC_TRIPLEto the unnormalizedx86_64-w64-mingw32, as the JuliaGPU PoCL JLLs do, didn't get the flag, so the wrappers passed vectors indirectly while the kernel library takes them directly. This also matches-mingw32.Carried by the JuliaGPU PoCL JLLs (Yggdrasil
P/pocl/pocl_next0020). It's a one-line fix that could go upstream if they want it.