Add subresourceRange to blit barrier - #446
Open
dagiantrat64 wants to merge 1 commit into
Open
Conversation
To match the source since it wasn't included in the main guide but is necessary for it to function
There was a problem hiding this comment.
Pull request overview
Updates the mipmap-generation documentation code snippet to include subresourceRange on the blit-related image memory barrier, matching the reference implementation and ensuring the shown code functions correctly.
Changes:
- Adds
.subresourceRangeto thevk::ImageMemoryBarrierdesignated initializer in the mipmap generation example.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| .srcQueueFamilyIndex = vk::QueueFamilyIgnored, | ||
| .dstQueueFamilyIndex = vk::QueueFamilyIgnored, | ||
| .image = image, | ||
| .subresourceRange = {.aspectMask = vk::ImageAspectFlagBits::eColor, .levelCount = 1, .layerCount = 1}}; |
asuessenbach
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To match the source since it wasn't included in the main guide but is necessary for it to function