Repository navigation
Gate the future doc example on alloc (#193) - #194
Merged
Merged
Conversation
CryZe
approved these changes
Oct 11, 2026
CryZe
left a comment
Collaborator
There was a problem hiding this comment.
Reproduced the unresolved run_tasks import on master without alloc. With this change, the Unity doctests pass both without alloc (21 passed) and with alloc (23 passed), and all seven CI checks are green. No public API changes.
Non-blocking follow-up: CI should also run cargo test --no-default-features --features unity so allocation-free doctests are covered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #193.
The
run_tasksexample in thefuturemodule docs now only compiles its hiddenuseandasync fnwhenallocis on. Withoutalloc, the example is empty, socargo test --no-default-features --features unitypasses again.With
alloc, the whole example still compiles. I checked by putting a type error in it, which fails withallocand is skipped without it.