Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #197.
The walk now skips a jump out of the module at the start of a function and goes on behind it. A jump through a pointer inside the module is an import thunk, so the walk still stops there.
When the hook ends in the middle of an instruction, the walk takes the end of that instruction from the function's unwind info and goes on there. That only works on Windows x64, since nothing else has unwind info.
The first commit splits
walkinto smaller functions and doesn't change anything.cargo test --all-featurescovers the hook shapes, x86, ELF, thes_Assembliesgetter, an import thunk and the unwind resume. Big Walk with MelonLoader 0.7.3 attaches with this.