Repository navigation
refactor: clarify optional checks, reduce copies, and tighten macro scopes - #5936
Merged
Merged
Conversation
Resolve cpp:S6991 by constructing platform-specific parameter arrays before instantiating the test suites.
Resolve all 14 cpp:S7172 findings while preserving zero and negative property values. Cover zero versus absent NVIDIA undo values.
Resolve all five cpp:S1238 findings and enforce the public input-only signatures with compile-time regression checks.
Resolve all seven cpp:S125 findings, preserving useful explanations as prose or Doxygen documentation.
Resolve all ten cpp:S6030 findings and verify first-value configuration semantics and mailbox channel reuse.
Member
Author
|
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5936 +/- ##
==========================================
+ Coverage 45.21% 45.48% +0.27%
==========================================
Files 139 139
Lines 30024 30067 +43
Branches 12965 12965
==========================================
+ Hits 13574 13677 +103
+ Misses 14599 13514 -1085
- Partials 1851 2876 +1025
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 24 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #5936 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: AppImage-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-AMD64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-ARM64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-arm64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Resolve all 16 cpp:S959 findings by matching Doxygen macro guards, using explicit NVAPI return types, and removing the obsolete NTDDI override.
Complete the remaining two cpp:S7172 baseline findings in encoder options and Wayland plane export.
Resolve all seven cpp:S5415 findings without changing ownership contracts. Cover preparation-command values and non-owning packet replacement views with focused regression tests.
Preserve the existing Windows 10 API target without redefining NTDDI_VERSION after headers have selected declarations. Leave the requested TODO to revisit the Windows 11 minimum API target.
ReenigneArcher
changed the title
ReenigneArcher
force-pushed
the
codex/sonar-explicit-types
branch
from
October 15, 2026 13:53
b60b500 to
756851c
Compare
|
ReenigneArcher
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve 100 existing findings from the complete 814-finding master baseline at f86c4c9: 95 across 13 complete rule groups, plus the five Avahi error-description TODOs requested for this PR. Each rule cleanup is committed separately.
The changes clarify optional presence checks and template constraints, avoid redundant copies and ineffective moves, use keyed insertion without constructing duplicate entries, and improve macro scope, parameter names, comments, and switch layout. Existing enums and logging behavior are preserved. Avahi error comments now describe the DNS update errors and sentinel accurately. The Windows 10 API target is set before headers can select an SDK default, with a TODO to revisit the Windows 11 minimum target.
cpp:S5421 remains excluded. All 31 cpp:S3642 enum findings and 10 cpp:S6190 logging findings are deferred. The remaining cpp:S1135 findings outside the requested Avahi comments are outside this cleanup; the Windows target TODO is explicitly retained for later work.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
Comments, renames, local enum imports, and switch label placement preserve behavior and are checked through compilation, existing tests, focused mapping tests, and Doxygen. Hardware-dependent Linux capture and NVIDIA driver restoration cannot be fully exercised on this Windows host; no 100% whole-patch coverage claim is made.
Sonar analysis completed for 6c92ced with zero unintended introduced findings. The sole remaining PR finding is the explicitly requested cpp:S1135 Windows API-target TODO in src/platform/windows/misc.cpp; it is deliberately retained, so the quality gate is ERROR. All 100 implemented baseline sites have been reconciled with the source. PR-scoped analysis does not prove whole-branch rule closure.
Hosted platform checks for the follow-up head are still running; local validation is recorded above.
Type of Change
Checklist
AI Usage
See our AI usage policy.