Skip to content

docs(configuration): Add missing entry for portal capture and clarify kwingrab+flatpak - #5938

Merged
ReenigneArcher merged 1 commit into
LizardByte:masterfrom
Kishi85:doc-update-kwingrab-flatpak
Oct 15, 2026
Merged

ReenigneArcher merged 1 commit into
LizardByte:masterfrom
Kishi85:doc-update-kwingrab-flatpak

Conversation

@Kishi85

@Kishi85 Kishi85 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adds the missing configuration doc for portal capture option and adds a warning about using kwingrab with Flatpak recommending using portal instead.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@psyke83

psyke83 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

No objection to this PR, but you should know that KWin via Plasma 6.8 onward will have different behaviour: https://invent.kde.org/plasma/kwin/-/merge_requests/6057

@ReenigneArcher
ReenigneArcher force-pushed the doc-update-kwingrab-flatpak branch from b3914df to 52808ef Compare October 15, 2026 16:11
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.48%. Comparing base (c732a81) to head (52808ef).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #5938    +/-   ##
========================================
  Coverage   45.48%   45.48%            
========================================
  Files         139      139            
  Lines       30067    30067            
  Branches    12970    12969     -1     
========================================
  Hits        13677    13677            
+ Misses      14894    14535   -359     
- Partials     1496     1855   +359     
Flag Coverage Δ
Alpine-aarch64 29.64% <ø> (+<0.01%) ⬆️
Alpine-x86_64 29.75% <ø> (ø)
Archlinux 27.33% <ø> (ø)
FreeBSD-amd64 29.59% <ø> (+<0.01%) ⬆️
Homebrew-macos-15 46.67% <ø> (ø)
Homebrew-macos-26 47.06% <ø> (ø)
Homebrew-ubuntu-24.04 30.73% <ø> (ø)
Linux-AppImage-aarch64 32.49% <ø> (+<0.01%) ⬆️
Linux-AppImage-x86_64 32.73% <ø> (ø)
PowerShell 100.00% <ø> (ø)
Web-UI 56.65% <ø> (ø)
Windows-AMD64 38.73% <ø> (ø)
Windows-ARM64 32.90% <ø> (-0.01%) ⬇️
macOS-arm64 38.48% <ø> (ø)
macOS-x86_64 39.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 45 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c732a81...52808ef. Read the comment docs.

@github-actions

Copy link
Copy Markdown
Last Updated 2026-10-15 17:44:12 UTC
Source Run CI Run #6310
Commit 52808efedb11bbfdf79becafc57235da453d4b79

Screenshot Comparison

PR #5938 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@ReenigneArcher
ReenigneArcher merged commit d288b3b into LizardByte:master Oct 15, 2026
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

capture = kwin cannot satisfy KWin's permission check under Flatpak

3 participants