docs(config): make the capture Choices cell span every row by nikzasel · Pull Request #5949 · LizardByte/Sunshine

nikzasel · 2026-10-17T07:15:18Z

Description

The capture table in docs/configuration.md lists seven methods, but its Choices cell spans six rows, so the wgc row falls out of the column.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

Documentation only. The docs build (doxygen) was not run.

Type of Change

Checklist

Code follows the style guidelines of this project
Code has been self-reviewed
Code has been commented, particularly in hard-to-understand areas
Code docstring/documentation-blocks for new or existing methods/components have been added or updated
Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

AI tools were used while preparing this PR

This pull request was generated by Claude Code, Claude Opus 5.5

chatgpt-codex-connector · 2026-10-17T07:15:30Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-17T07:16:54.797985Z	`73bb5ed`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

ReenigneArcher

One correction remains before merging: the Choices cell needs to span the eighth capture method now present in master; see the inline suggestion.

Validation: the patch applies cleanly to master (1582fff) with no whitespace errors. A focused Python table check reproduces the remaining alignment problem and passes with the suggested span of eight. The Sunshine documentation build passed for 73bb5ed. The PR has no merge conflicts.

Verification limit: GitHub Actions await maintainer approval, and the GH-Pages documentation check timed out waiting for its dependent job, leaving those checks unverified.

_{Review completed by Codex | Model: gpt-6.1-sol | Thinking: xhigh}

The capture table lists seven methods, but its Choices cell spans six rows, so the wgc row falls out of the column.

Co-authored-by: Dave Lane <42013603+ReenigneArcher@users.noreply.github.com>

codecov · 2026-10-17T23:25:48Z

Bundle Report

Changes will decrease total bundle size by 1.48kB (-0.04%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
sunshine-esm	994.65kB	-1.48kB (-0.15%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
~~*`images/logo-.svg`*~~ (Deleted)*	-1.48kB	0 bytes	-100.0% 🗑️

sonarqubecloud · 2026-10-17T23:36:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2026-10-18T00:13:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.11%. Comparing base (d60255f) to head (f13c30b).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5949   +/-   ##
=======================================
  Coverage   46.11%   46.11%           
=======================================
  Files         141      141           
  Lines       30437    30437           
  Branches    13114    13114           
=======================================
  Hits        14035    14035           
+ Misses      15285    15229   -56     
- Partials     1117     1173   +56

Flag	Coverage Δ
Alpine-aarch64	`30.70% <ø> (-0.01%)`	⬇️
Alpine-x86_64	`30.83% <ø> (ø)`
Archlinux	`28.48% <ø> (ø)`
FreeBSD-amd64	`30.49% <ø> (ø)`
Homebrew-macos-15	`46.97% <ø> (+0.02%)`	⬆️
Homebrew-macos-26	`47.36% <ø> (+0.01%)`	⬆️
Homebrew-ubuntu-24.04	`31.46% <ø> (ø)`
Linux-AppImage-aarch64	`33.61% <ø> (ø)`
Linux-AppImage-x86_64	`33.86% <ø> (ø)`
PowerShell	`100.00% <ø> (ø)`
Web-UI	`56.65% <ø> (ø)`
Windows-AMD64	`38.98% <ø> (ø)`
Windows-ARM64	`33.23% <ø> (ø)`
macOS-arm64	`38.87% <ø> (-0.01%)`	⬇️
macOS-x86_64	`39.46% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 17 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60255f...f13c30b. Read the comment docs.

github-actions · 2026-10-18T00:51:14Z


Last Updated	2026-10-18 00:51:11 UTC
Source Run	CI Run #6370
Commit	`f13c30b119fb2be62f865cf3717c8e7d9f96a333`

Screenshot Comparison

PR #5949 screenshots vs screenshots baseline.

Matrix: `AppImage-aarch64`

Image	Baseline	PR
`sunshine_tray_initial.png`
`sunshine_tray_menu.png`
`sunshine_tray_pairing_request.png`
`sunshine_tray_paused.png`
`sunshine_tray_stopped.png`
`sunshine_tray_streaming.png`
`sunshine_tray_tooltip.png`

Matrix: `AppImage-x86_64`

Image	Baseline	PR
`sunshine_tray_initial.png`
`sunshine_tray_menu.png`
`sunshine_tray_pairing_request.png`
`sunshine_tray_paused.png`
`sunshine_tray_stopped.png`
`sunshine_tray_streaming.png`
`sunshine_tray_tooltip.png`

Matrix: `Windows-AMD64`

Image	Baseline	PR
`sunshine_tray_initial.png`
`sunshine_tray_menu.png`
`sunshine_tray_pairing_request.png`
`sunshine_tray_paused.png`
`sunshine_tray_stopped.png`
`sunshine_tray_streaming.png`
`sunshine_tray_tooltip.png`

Matrix: `Windows-ARM64`

Image	Baseline	PR
`sunshine_tray_initial.png`
`sunshine_tray_menu.png`
`sunshine_tray_pairing_request.png`
`sunshine_tray_paused.png`
`sunshine_tray_stopped.png`
`sunshine_tray_streaming.png`
`sunshine_tray_tooltip.png`

Matrix: `macOS-arm64`

Image	Baseline	PR
`sunshine_tray_initial.png`
`sunshine_tray_menu.png`
`sunshine_tray_pairing_request.png`
`sunshine_tray_paused.png`
`sunshine_tray_stopped.png`
`sunshine_tray_streaming.png`
`sunshine_tray_tooltip.png`

Matrix: `macOS-x86_64`

Image	Baseline	PR
`sunshine_tray_initial.png`
`sunshine_tray_menu.png`
`sunshine_tray_pairing_request.png`
`sunshine_tray_paused.png`
`sunshine_tray_stopped.png`
`sunshine_tray_streaming.png`
`sunshine_tray_tooltip.png`

ReenigneArcher requested changes Oct 17, 2026

View reviewed changes

Comment thread docs/configuration.md Outdated

ReenigneArcher force-pushed the fix/docs-capture-rowspan branch from 73bb5ed to ac3fafe Compare October 17, 2026 13:22

nikzasel requested a review from ReenigneArcher October 17, 2026 20:04

nikzasel and others added 2 commits October 17, 2026 19:18

docs(config): make the capture Choices cell span every row

cc9aa6e

The capture table lists seven methods, but its Choices cell spans six rows, so the wgc row falls out of the column.

Update docs/configuration.md

f13c30b

Co-authored-by: Dave Lane <42013603+ReenigneArcher@users.noreply.github.com>

ReenigneArcher force-pushed the fix/docs-capture-rowspan branch from 569002c to f13c30b Compare October 17, 2026 23:18

ReenigneArcher approved these changes Oct 17, 2026

View reviewed changes

ReenigneArcher merged commit 3d6e1d6 into LizardByte:master Oct 18, 2026
84 checks passed

Navigation Menu

Repository navigation

docs(config): make the capture Choices cell span every row - #5949

docs(config): make the capture Choices cell span every row#5949
ReenigneArcher merged 2 commits into
LizardByte:masterfrom
nikzasel:fix/docs-capture-rowspan

nikzasel commented Oct 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 17, 2026 •

edited

Loading

Uh oh!

ReenigneArcher left a comment

Uh oh!

Uh oh!

codecov Bot commented Oct 17, 2026 •

edited

Loading

Assets Changed:

Uh oh!

sonarqubecloud Bot commented Oct 17, 2026

Uh oh!

codecov Bot commented Oct 18, 2026

Uh oh!

github-actions Bot commented Oct 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nikzasel commented Oct 17, 2026

Description

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

Type of Change

Checklist

AI Usage

Uh oh!

chatgpt-codex-connector Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

ReenigneArcher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

sonarqubecloud Bot commented Oct 17, 2026

Quality Gate passed

Uh oh!

codecov Bot commented Oct 18, 2026

Codecov Report

Uh oh!

github-actions Bot commented Oct 18, 2026

Screenshot Comparison

Matrix: AppImage-aarch64

Matrix: AppImage-x86_64

Matrix: Windows-AMD64

Matrix: Windows-ARM64

Matrix: macOS-arm64

Matrix: macOS-x86_64

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chatgpt-codex-connector Bot commented Oct 17, 2026 •

edited

Loading

codecov Bot commented Oct 17, 2026 •

edited

Loading

Matrix: `AppImage-aarch64`

Matrix: `AppImage-x86_64`

Matrix: `Windows-AMD64`

Matrix: `Windows-ARM64`

Matrix: `macOS-arm64`

Matrix: `macOS-x86_64`