[ReenigneArcher]

Description

Replace direct GoogleTest includes with tests_common.h so plain TEST cases use the shared BaseTest setup and output capture. Normalize test include groups and comments, and document the authoring and PR review conventions in AGENTS.md, including necessary include-order exceptions.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

• Windows MSYS2 UCRT64 build of test_sunshine passed.
• Affected test suites: 68 passed, 1 skipped. The skipped test only configures tray visibility on Windows runners.
• uv run --locked lb-update-clang-format and git diff --check passed.
• Confirmed all 67 test translation units include the common header and no direct GoogleTest includes remain.
• Existing test cases were migrated without changing their assertions or production methods; no additional regression cases were added.
• Linux-only test bodies were not compiled or run on Windows.

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

• AI tools were used while preparing this PR

This pull request was generated by Codex using gpt-6.1-sol, extra high thinking level.

[ReenigneArcher]

This pull request was generated by Codex using gpt-6.1-sol, extra high thinking level.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Bundle Report

Bundle size has no change ✅

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.11%. Comparing base (fb47328) to head (17326c3).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5951      +/-   ##
==========================================
+ Coverage   46.07%   46.11%   +0.04%     
==========================================
  Files         141      141              
  Lines       30434    30437       +3     
  Branches    13113    13115       +2     
==========================================
+ Hits        14021    14035      +14     
+ Misses      15252    13636    -1616     
- Partials     1161     2766    +1605     

Flag	Coverage Δ
Alpine-aarch64	30.71% <ø> (+<0.01%)	⬆️
Alpine-x86_64	30.83% <ø> (ø)
Archlinux	28.48% <ø> (ø)
FreeBSD-amd64	30.49% <ø> (ø)
Homebrew-macos-15	46.97% <ø> (ø)
Homebrew-macos-26	47.36% <ø> (ø)
Homebrew-ubuntu-24.04	31.46% <ø> (ø)
Linux-AppImage-aarch64	33.62% <ø> (ø)
Linux-AppImage-x86_64	33.86% <ø> (ø)
PowerShell	100.00% <ø> (ø)
Web-UI	56.65% <ø> (ø)
Windows-AMD64	38.98% <ø> (ø)
Windows-ARM64	33.23% <ø> (+<0.01%)	⬆️
macOS-arm64	38.88% <ø> (+<0.01%)	⬆️
macOS-x86_64	39.46% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 46 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb47328...17326c3. Read the comment docs.

[github-actions]

Build artifacts

Artifacts from workflow run 39044305338:

• build-Alpine-aarch64
• build-Alpine-x86_64
• build-Archlinux
• build-Docker-debian-trixie-linux-amd64
• build-Docker-ubuntu-22.04-linux-amd64
• build-Docker-ubuntu-24.04-linux-amd64
• build-Docker-ubuntu-26.04-linux-amd64
• build-Docker-ubuntu-26.10-linux-amd64
• build-FreeBSD-amd64
• build-Homebrew
• build-Linux-AppImage-aarch64
• build-Linux-AppImage-x86_64
• build-macOS-arm64
• build-macOS-x86_64
• build-Sunshine-0.0.5951-1.fc43.aarch64.rpm
• build-Sunshine-0.0.5951-1.fc43.x86_64.rpm
• build-Sunshine-0.0.5951-1.fc44.aarch64.rpm
• build-Sunshine-0.0.5951-1.fc44.x86_64.rpm
• build-Sunshine-0.0.5951-1.fc45.aarch64.rpm
• build-Sunshine-0.0.5951-1.fc45.x86_64.rpm
• build-Sunshine-0.0.5951-1.fc46.aarch64.rpm
• build-Sunshine-0.0.5951-1.fc46.x86_64.rpm
• build-Sunshine-0.0.5951-1.suse.lp160.aarch64.rpm
• build-Sunshine-0.0.5951-1.suse.lp160.x86_64.rpm
• build-Sunshine-0.0.5951-1.suse.tw20261011.aarch64.rpm
• build-Sunshine-0.0.5951-1.suse.tw20261014.x86_64.rpm
• build-Windows-AMD64
• build-Windows-ARM64

_{You must be signed in to GitHub to download workflow artifacts.}

[github-actions]

Last Updated	2026-10-17 16:43:03 UTC
Source Run	CI Run #6361
Commit	17326c3229ac926bb56a03611f48d6000ae764ef

Screenshot Comparison

PR #5951 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image	Baseline	PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image	Baseline	PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image	Baseline	PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image	Baseline	PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image	Baseline	PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image	Baseline	PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png