Repository navigation
SignPath follow-ups: package version, artifact cleanup, signing policy - #731
Merged
Merged
Conversation
- ColumnizerLib nupkg got 1.40.4 because Directory.Build.props pins PackageVersion, which wins over the Version the build passes. The pack step now passes PackageVersion too. - The signing workflow deletes its two unsigned artifacts after a successful run, so the unsigned installer can't be downloaded by mistake. - README gets the code signing policy section SignPath Foundation requires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from the first test-signing run (#730).
1.40.4while everything else was1.50.0.src/Directory.Build.propspins<PackageVersion>1.40.4.0</PackageVersion>, which wins over theVersionthe build passes.ColumnizerLibCreatenow also passesPackageVersion. The props file is unchanged, so local builds behave as before.unsigned-appand the unsigned installer artifact. The installer artifact is named after its file, so it was easy to confuse with the signed one. They are kept when a step fails, for debugging. This needsactions: writeinstead ofactions: read.Test plan
./build.ps1 --target ColumnizerLibCreate --configuration Release --skip TestproducesLogExpert.ColumnizerLib.1.50.0.nupkgtest-signing. Onlysigned-packages-test-signingshould remain, and the nupkg in it should have the GitVersion numberStill to do later: Add the code signing policy on to the release page. That fits together with moving signing into
release.yml.