Skip to content

fix: Nest Loki_Base::config ACL resource under Magento_Backend::admin #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jissereitsma merged 2 commits into from
Oct 2, 2026
Merged

fix: Nest Loki_Base::config ACL resource under Magento_Backend::admin #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb856fc
fix: Nest Loki_Base::config ACL resource under Stores > Configuration
Sep 28, 2026
ab8121d
fix: Hang Loki_Base::config directly under Magento_Backend::admin
Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]
### Fixed
- ACL resource `Loki_Base::config` is now a child of `Magento_Backend::admin` instead of a top-level sibling of it, which broke integration ACL resolution and hid it from restricted admin roles
- `MageCookies.getAll()` no longer truncates cookie values containing `=` (e.g. Cookiebot `CookieConsent`)
- Playwright test no longer depends on a checkout or catalog product (fails in CI)
- `script-container.phtml` fatal "Undefined variable $childRenderer" when `Loki_Components` is not installed: `LokiScript` now assigns its own `ChildRenderer`
Expand Down
4 changes: 3 additions & 1 deletion etc/acl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Acl/etc/acl.xsd">
<acl>
<resources>
<resource id="Loki_Base::config" title="Loki Base" sortOrder="10"/>
<resource id="Magento_Backend::admin">
<resource id="Loki_Base::config" title="Loki Base" translate="title" sortOrder="10"/>
</resource>
</resources>
</acl>
</config>