Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it fix
When using a custom
Lua.addonManager.repositoryPaththe addon manager places it underworkspaceStoragebut the server always looks underglobalStorage, where it can only find the default one.How is it fixed
This was already noticed and diagnosed over a year ago here LuaLS/lua-language-server#3230 but it apparently didn't result in a PR.
So this PR just tries to apply these fixes.
I also tested this with a custom
Lua.addonManager.repositoryPathand everything appears to work as expected.But I'm not sure if activating
addonManagerbeforelanguageservermight have some side effects.