Skip to content

refactor: replace client-side drawer with a dedicated /plugin/[id] page #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ClausValcaTD merged 1 commit into from
Nov 4, 2026
Merged

refactor: replace client-side drawer with a dedicated /plugin/[id] page #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ with a direct call to action to the [submission guide](./CONTRIBUTING.md).

| Path | Purpose |
| --- | --- |
| `src/pages/index.astro` | Storefront (search, filters, cards, detail drawer) |
| `src/pages/index.astro` | Storefront (search, filters, cards); `?ext=`/`?id=` redirect to the detail page |
| `src/pages/plugin/[id].astro` | Server-rendered plugin details (README, routes, install, manifest) |
| `src/pages/dashboard.astro` | Signed-in publisher dashboard (create + list publishers) |
| `src/pages/dashboard/settings.astro` | Account settings (display name + avatar upload) |
| `src/pages/dashboard/publisher/[id].astro` | Owner-only publisher profile editor |
Expand All @@ -47,7 +48,7 @@ with a direct call to action to the [submission guide](./CONTRIBUTING.md).
| `src/pages/api/user/profile.ts` | `PATCH` the signed-in user's display name + avatar |
| `src/pages/api/publishers/create.ts` | Creates a publisher owned by the signed-in user |
| `src/pages/api/publishers/[id].ts` | `GET` a publisher profile + stats; `PATCH` the owner's branding |
| `src/components/` | `Navbar`, `Card`, `DetailDrawer`, `CategoryFilter`, `Icon`, `ImageField` |
| `src/components/` | `Navbar`, `Card`, `CategoryFilter`, `Icon`, `ImageField` |
| `src/lib/db.ts` | Typed D1 access layer for the catalog |
| `src/lib/session.ts` | HMAC-signed session token (sign/verify) |
| `src/lib/auth.ts` | Session helpers shared by pages and API routes |
Expand Down
20 changes: 13 additions & 7 deletions src/components/Card.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,14 @@ const cli = `openrom-core --install-plugin ${plugin.id}`;

<div class="min-w-0 flex-1">
<div class="flex items-center gap-1.5">
<h3 class="truncate text-sm font-semibold text-zinc-100">{plugin.name}</h3>
<h3 class="truncate text-sm font-semibold text-zinc-100">
<a
href={`/plugin/${plugin.id}`}
class="after:absolute after:inset-0 after:content-['']"
>
{plugin.name}
</a>
</h3>
{
plugin.publisherVerified && (
<Icon name="badge-check" class="h-4 w-4 shrink-0 text-cyan-400" />
Expand All @@ -54,7 +61,7 @@ const cli = `openrom-core --install-plugin ${plugin.id}`;
plugin.publisherId ? (
<a
href={`/publisher/${plugin.publisherId}`}
class="transition hover:text-cyan-300"
class="relative z-10 transition hover:text-cyan-300"
title={`View ${plugin.publisherName}'s profile`}
>
{plugin.publisherName}
Expand Down Expand Up @@ -106,7 +113,7 @@ const cli = `openrom-core --install-plugin ${plugin.id}`;
</span>
</div>

<div class="flex items-center gap-2">
<div class="relative z-10 flex items-center gap-2">
<button
type="button"
data-copy-cli={cli}
Expand All @@ -116,14 +123,13 @@ const cli = `openrom-core --install-plugin ${plugin.id}`;
>
<Icon name="copy" class="h-4 w-4" />
</button>
<button
type="button"
data-open-detail={plugin.id}
<a
href={`/plugin/${plugin.id}`}
class="inline-flex h-8 items-center gap-1.5 rounded-lg border border-zinc-800 px-3 text-xs font-medium text-zinc-300 transition hover:border-cyan-500/40 hover:text-cyan-300"
>
Details
<Icon name="chevron-right" class="h-3.5 w-3.5" />
</button>
</a>
{
published ? (
<a
Expand Down
291 changes: 0 additions & 291 deletions src/components/DetailDrawer.astro
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions src/components/Icon.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const ICONS: Record<string, string> = {
cpu: '<rect width="16" height="16" x="4" y="4" rx="2"/><rect width="6" height="6" x="9" y="9" rx="1"/><path d="M15 2v2M15 20v2M2 15h2M2 9h2M20 15h2M20 9h2M9 2v2M9 20v2"/>',
sparkles:
'<path d="M9.937 15.5A2 2 0 0 0 8.5 14.063l-6.135-1.582a.5.5 0 0 1 0-.962L8.5 9.936A2 2 0 0 0 9.937 8.5l1.582-6.135a.5.5 0 0 1 .963 0L14.063 8.5A2 2 0 0 0 15.5 9.937l6.135 1.581a.5.5 0 0 1 0 .964L15.5 14.063a2 2 0 0 0-1.437 1.437l-1.582 6.135a.5.5 0 0 1-.963 0z"/><path d="M20 3v4M22 5h-4M4 17v2M5 18H3"/>',
zap: '<path d="M4 14a1 1 0 0 1-.78-1.63l9.9-10.2a.5.5 0 0 1 .86.46l-1.92 6.02A1 1 0 0 0 13 10h7a1 1 0 0 1 .78 1.63l-9.9 10.2a.5.5 0 0 1-.86-.46l1.92-6.02A1 1 0 0 0 11 14z"/>',
monitor: '<rect width="20" height="14" x="2" y="3" rx="2"/><line x1="8" x2="16" y1="21" y2="21"/><line x1="12" x2="12" y1="17" y2="21"/>',
terminal: '<polyline points="4 17 10 11 4 5"/><line x1="12" x2="20" y1="19" y2="19"/>',
apple: '<path d="M12 20.94c1.5 0 2.75 1.06 4 1.06 3 0 6-8 6-12.22A4.91 4.91 0 0 0 17 5c-2.22 0-4 1.44-5 2-1-.56-2.78-2-5-2a4.9 4.9 0 0 0-5 4.78C2 14 5 22 8 22c1.25 0 2.5-1.06 4-1.06Z"/><path d="M10 2c1 .5 2 2 2 5"/>',
Expand Down
Loading
Loading