Repository navigation
Skye: remove unnecessary duplicate computation of xnefer - #1122
Conversation
|
I am not sure what the MESA preference is on disabling code -- a lot was already commented out, so I did the same. I would just as well delete it (it is in git after all). |
the mass fractions were being normalized by the number fraction normalization, but this array was never accessed again, so no harm was being done.
|
if the code had no purpose, it's fine to delete. |
|
Feel free to remove the other commented code as well :) |
|
can I also go after all the unused variable warnings ? (in a separate PR) |
yes! just keep in mind some things were intentionally left there for future analytic composition partials, which I'm using here https://github.com/MESAHub/mesa/tree/EbF/eos_partials. |
|
|
|
If there is no way the function can fail, I don't think it makes sense to keep |
|
It looks like tests pass. I am going to fix the uninitialized |
The computation in
compute_ideal_eleis immediately overwritten byin the caller. This means that 10 interpolations (calls to
h3) are unnecessary.This change in the way this is computed was done in f5a6efe
This also removes some dead code that did an incorrect normalization on mass fractions.
This change should be bitwise identical.