Repository navigation
Conversation
for the double precision bicub_db, implicit typing was being used resulting in intermediate calculations stored as single precision for the dingle precision bicub_sg, 1/36 was stored as an integer, resulting in 0. Also fix a comment in ferguson that pointed to the wrong interplation when an error was raised.
zingale
requested review from
Debraheem,
fxt44,
rhdtownsend and
warrickball
as code owners
November 20, 2026 14:00
Member
|
Wow, i will have a look soon. Can you check where these splines are called? Does it affect bicubic splines in kap? Much of kap is piped through the bicubic splines... |
Collaborator
Author
|
From codex: The double precision fix affects callers of interp_evbicub_db:
The single precision fix (1/36) affects:
|
Member
|
Oh my! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for the double precision bicub_db, implicit typing was being used resulting in intermediate calculations stored as single precision
for the single precision bicub_sg, 1/36 was stored as an integer, resulting in 0.
Also fix a comment in ferguson that pointed to the wrong interplation when an error was raised.