Write merged input yaml to output dir - #119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of #99, merged input files are written to the output directory as
merged-input.yaml. This allows tracking of what parameters were used to run APCEMM with 2 caveats:merged-input.yamlForce seed value = Fthen APCEMM generates a random seed based on a unix timestamp. Themerged-input.yamldoes not record this seed and just copy/pastes the merged value in the input files. I kept this as is for now because right now themerged-input.yamlis a record of what was passed to APCEMM. If we want it to be a record of what APCEMM ran with then it would make sense to record the seed in the dedicated yaml field and flip force seed to true, such that re-running APCEMM withmerged-input.yamlactually fully reproduces the simulation. Depends on what exactly we want this file to be