Skip to content

feat: tolerate boundary conditions on inactive cells - #2863

Draft
wpbonelli wants to merge 3 commits into
MODFLOW-ORG:developfrom
wpbonelli:warn-inactive
Draft

feat: tolerate boundary conditions on inactive cells#2863
wpbonelli wants to merge 3 commits into
MODFLOW-ORG:developfrom
wpbonelli:warn-inactive

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Jun 25, 2026

Copy link
Copy Markdown
Member

Allow boundary conditions to be placed in inactive or pass-through cells, issuing a warning rather than an error. Previously this caused a fatal error in most packages; some were already permissive.

Changes to base types:

  • BndExtTypecellid_to_nlist and nodeu_to_nlist: store_errorstore_warning
  • DisBaseTyperead_list: same treatment
  • BndTypebnd_fc: skip non-positive node numbers

Changes to boundary packages (add guards for non-positive node numbers):

  • gwf-wel, gwf-drn, gwf-riv, gwf-chd, gwf-ghb (also corrects == 0 to <= 0)
  • gwt-cnc, gwt-src
  • gwe-ctp, gwe-esl
  • swf-flw, swf-cdb, swf-zdg (shared by SWF, CHF, and OLF models; swf-chd reuses gwf-chd)

No changes needed (already skipped non-positive node numbers):

  • gwf-rch, gwf-evt
  • swf-pcp, swf-evp

Checklist of items for pull request

  • Replaced section above with description of pull request
  • Added new test or modified an existing test
  • Ran ruff on new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.
  • Formatted new and modified Fortran source files with fprettify
  • Added doxygen comments to new and modified procedures
  • Updated develop.toml with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • Removed checklist items not relevant to this pull request

@wpbonelli wpbonelli added this to the 6.8.0 milestone Jun 25, 2026
@wpbonelli wpbonelli changed the title feat: allow/warn boundary conditions on inactive cells feat: tolerate boundary conditions on inactive cells Jun 25, 2026
@wpbonelli wpbonelli added the question Needs someone's attention label Jun 26, 2026
@wpbonelli wpbonelli modified the milestones: 6.8.0, 6.9.0 Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement question Needs someone's attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant