Skip to content

Logo über next/image, Lizenzprüfung als Positivliste, Actions aktualisiert - #34

Merged
Musiker15 merged 3 commits into
mainfrom
fix/logo-next-image
Oct 30, 2026
Merged

Musiker15 merged 3 commits into
mainfrom
fix/logo-next-image

Conversation

@Musiker15

@Musiker15 Musiker15 commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Header und Footer haben das volle logo.png geladen (678 × 671 px, 176 KB), obwohl es nur mit 32 bis 36 px angezeigt wird. Mit next/image kommt eine passend verkleinerte WebP-Datei, dazu ein srcset für 2x. Damit sind auch die beiden Warnungen @next/next/no-img-element aus dem Code-Scan von #31 erledigt. Im Header lädt das Logo mit loading="eager", weil es immer sichtbar ist.

Die Dependency Review hat gewarnt, dass deny-licenses wegfällt (actions/dependency-review-action#997). Statt der Sperrliste GPL-2.0, GPL-3.0 steht jetzt eine Positivliste drin: alles, was heute im Lockfile vorkommt, plus AGPL-3.0-or-later als eigene Lizenz des Projekts. Die alte Liste hätte zum Beispiel AGPL durchgelassen.

actions/checkout steht überall auf v7 (codeql.yml hatte noch v4), actions/setup-node auf v7. Die Änderungen dort betreffen uns nicht, wir nutzen weder pull_request_target noch registry-url.

Geprüft: tsc und eslint lokal sauber, alle Workflows parsen als YAML.

Mirror to Codeberg läuft nur noch bei Pushes auf main und bei Tags. Der Trigger delete hat für jeden Branch, den ein gemergter PR oder Dependabot gelöscht hat, einen eigenen Lauf gestartet. Aufgeräumt wird auf Codeberg trotzdem, der nächste Push auf main entfernt den Branch dort mit --prune.

The header and footer showed the full 678 px, 176 KB logo.png at 32 to 36 px. next/image sends a scaled WebP instead, which also clears the no-img-element warning from the code scan.
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 3 package(s) with unknown licenses.
See the Details below.

License Issues

.github/workflows/eslint.yml

PackageVersionLicenseIssue Type
actions/checkout7.*.*NullUnknown License
actions/setup-node7.*.*NullUnknown License

.github/workflows/secret-scanning.yml

PackageVersionLicenseIssue Type
actions/checkout7.*.*NullUnknown License
Allowed Licenses: MIT, ISC, 0BSD, BSD-2-Clause, BSD-3-Clause, Apache-2.0, BlueOak-1.0.0, CC0-1.0, CC-BY-4.0, OFL-1.1, MPL-2.0, LGPL-3.0-or-later, AGPL-3.0-or-later

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/checkout 7.*.* 🟢 5.9
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained⚠️ 00 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Packaging⚠️ -1packaging workflow not detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 9security policy file detected
SAST🟢 10SAST tool is run on all commits
Branch-Protection🟢 6branch protection is not maximal on development and all release branches
actions/actions/setup-node 7.*.* 🟢 6.4
Details
CheckScoreReason
Maintained🟢 1016 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
Binary-Artifacts🟢 9binaries present in source code
Code-Review🟢 10all changesets reviewed
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies🟢 5dependency not pinned by hash detected -- score normalized to 5
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 9security policy file detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
SAST🟢 10SAST tool is run on all commits
actions/actions/checkout 7.*.* 🟢 5.9
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained⚠️ 00 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Packaging⚠️ -1packaging workflow not detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 9security policy file detected
SAST🟢 10SAST tool is run on all commits
Branch-Protection🟢 6branch protection is not maximal on development and all release branches

Scanned Files

  • .github/workflows/eslint.yml
  • .github/workflows/secret-scanning.yml

The dependency review action deprecated deny-licenses (actions/dependency-review-action#997). A deny list of GPL-2.0 and GPL-3.0 also let AGPL and every other license through. The allow list holds what the lockfile has today plus AGPL-3.0-or-later, the project's own license. checkout and setup-node move to v7; neither change touches these workflows (no pull_request_target, no registry-url).
@Musiker15 Musiker15 changed the title Logo über next/image ausliefern Logo über next/image, Lizenzprüfung als Positivliste, Actions aktualisiert Oct 30, 2026
The delete trigger started a run for every branch a merged pull request or Dependabot removed. The next push to main prunes such a branch on Codeberg anyway.
@Musiker15
Musiker15 merged commit c7a26a2 into main Oct 30, 2026
8 checks passed
@Musiker15
Musiker15 deleted the fix/logo-next-image branch October 30, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant