Skip to content

Display mark last updated by - #8131

Open
akarki2005 wants to merge 5 commits into
MarkUsProject:masterfrom
akarki2005:display-mark-last-updated-by
Open

Display mark last updated by#8131
akarki2005 wants to merge 5 commits into
MarkUsProject:masterfrom
akarki2005:display-mark-last-updated-by

Conversation

@akarki2005

@akarki2005 akarki2005 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

Displays who last graded (updated the mark for) a criterion in the grading view, visible only to TAs and instructors. This mirrors the existing "creator"/"last editor" pattern already used for annotations.

The last_updated_by association on Mark already existed on the backend (#7878, #7885) but wasn't exposed anywhere in the UI. This PR:

  • Adds last_updated_by to the marks payload returned by ResultsController#show, gated behind the same TA/instructor/reviewer check already used for annotation creator visibility (can_view_grader_info), so students never receive this data at all.
  • Updates ResultsController#update_mark's JSON response to include last_updated_by, and patches local React state in result.jsx so the UI updates immediately after a mark change, without a reload.
  • Displays a small caption ("Last updated by ") under the mark for checkbox, flexible, and rubric criteria, hidden once results are released to students.

Screenshots

Screenshot 2026-08-18 at 12 25 19 PM

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • [N/A] I have updated the project documentation, if applicable.
    • This is required for new features.
  • [N/A] If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 32160271930

Coverage remained the same at 90.632%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 27 of 27 lines across 2 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 51799
Covered Lines: 47967
Line Coverage: 92.6%
Relevant Branches: 2500
Covered Branches: 1245
Branch Coverage: 49.8%
Branches in Coverage %: Yes
Coverage Strength: 129.7 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants