Repository navigation
Conversation
antiguru
added this pull request to stack #38942
September 24, 2026 08:52
antiguru
force-pushed
the
sqlfunc-convert-date
branch
from
September 24, 2026 10:14
39c186f to
f2e201e
Compare
antiguru
force-pushed
the
sqlfunc-convert-time
branch
from
September 24, 2026 10:14
f9edeb7 to
f65b9ea
Compare
antiguru
force-pushed
the
sqlfunc-convert-date
branch
from
September 24, 2026 14:29
f2e201e to
d45e6db
Compare
antiguru
force-pushed
the
sqlfunc-convert-time
branch
2 times, most recently
from
September 25, 2026 16:00
85c03fd to
a5999db
Compare
antiguru
force-pushed
the
sqlfunc-convert-date
branch
from
September 25, 2026 16:00
d45e6db to
893ab72
Compare
antiguru
force-pushed
the
sqlfunc-convert-time
branch
from
October 14, 2026 09:11
a5999db to
a95413f
Compare
`ExtractTime`, `DatePartTime` and `TimezoneTime` all read their payload in `call`, so each takes a `&self` receiver. None of them needs an output modifier. Each hand-written `output_sql_type` returned the derived output column type with nullability taken from the input, and the macro's unary tail is `output.nullable(nullable || (propagates_nulls && input_type.nullable))`, which for the non-nullable `NaiveTime` input and a non-nullable output collapses to exactly that. Per-override accounting, for all three: `call` becomes the function body, and `output_sql_type` becomes the derived default. Nothing else was overridden, so `could_error` stays derived, true for the two `Result` outputs and false for `TimezoneTime`, and `propagates_nulls` derives true from the non-nullable input. All three `Display` impls format the payload, so they stay hand-written under `skip_display = true`. `TimezoneTime`'s function name collides with the module's free `timezone_time`. The generated method is inherent, so the two coexist, and the body spells the call `self::timezone_time` to say which one it reaches. The registry reports only `sqlfunc_signature` moving, on all five records. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
antiguru
force-pushed
the
sqlfunc-convert-time
branch
from
October 14, 2026 15:18
a95413f to
a2e032f
Compare
antiguru
force-pushed
the
sqlfunc-convert-date
branch
from
October 14, 2026 15:18
27ae985 to
add3025
Compare
antiguru
removed this pull request from stack #38942
October 14, 2026 15:45
Member
Author
|
Folded into #39062, which now carries all twenty file conversions as separate commits, per review feedback to land them as one PR. Posted by Claude Code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
ExtractTime,DatePartTimeandTimezoneTimeto#[sqlfunc]. All three read their payload, so they take&self, and they need no output modifier. TheirDisplayimpls print the payload, so they stay hand-written underskip_display. The method generated forTimezoneTimehas the same name as the module's freetimezone_time, so the body callsself::timezone_timeexplicitly.The registry reports only
sqlfunc_signaturemoving, on all five records.Based on #39089.
🤖 Generated with Claude Code