Skip to content

[1.x] CMake: remove bogus BUILD_SHARED_LIBS dependent option #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robUx4 merged 2 commits into from
Aug 31, 2026
Merged

[1.x] CMake: remove bogus BUILD_SHARED_LIBS dependent option #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a8837f
CMake: remove bogus BUILD_SHARED_LIBS dependent option
robUx4 Aug 31, 2026
c08653c
CI: build static and share Windows libraries
robUx4 Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,23 @@ on:

jobs:
build_libebml:
name: ${{ matrix.config }} libebml for Windows
name: ${{ matrix.config }} libebml for Windows (${{ matrix.lib.name }})
runs-on: windows-latest
strategy:
fail-fast: false
matrix:
config: [Debug, Release]
lib: [
{ "name": "static", "option": "-DBUILD_SHARED_LIBS=OFF"},
{ "name": "shared", "option": "-DBUILD_SHARED_LIBS=ON"},
{ "name": "auto", "option": ""},
]
steps:
- name: Get pushed code
uses: actions/checkout@v7

- name: Configure CMake
run: cmake -S . -B _build -DCMAKE_INSTALL_PREFIX:STRING=${GITHUB_WORKSPACE}/_built -G Ninja
run: cmake -S . -B _build ${{ matrix.lib.option }} -DCMAKE_INSTALL_PREFIX:STRING=${GITHUB_WORKSPACE}/_built -G Ninja

- name: Build with CMake
run: cmake --build _build --config ${{ matrix.config }} --parallel
Expand Down
4 changes: 1 addition & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ cmake_minimum_required(VERSION 3.5)

project(ebml VERSION 1.4.7)

include(CMakeDependentOption)

include( FeatureSummary )
function(feature_info_on_off)
set(option_name ${ARGV0})
Expand All @@ -14,7 +12,7 @@ function(feature_info_on_off)
endif()
endfunction(feature_info_on_off)

cmake_dependent_option(BUILD_SHARED_LIBS "Build libebml as a shared library (except Windows)" OFF "NOT WIN32" OFF)
option(BUILD_SHARED_LIBS "Build libebml as a shared library (except Windows)" OFF)
feature_info_on_off(BUILD_SHARED_LIBS "will build as a dynamic library" "will build as a static library")

option(DISABLE_PKGCONFIG "Disable PkgConfig module generation" OFF)
Expand Down