Repository navigation
support headers only installation for utf8cpp - #358
Merged
Merged
Conversation
FreeBSD and OpenBSD package managers do not build utf8cpp, honoring the upstream installation instructions, so the use of find package fails as these distributions do not ship the cmake files. To fix these distros use find_path to find the include dir. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=298368
robUx4
approved these changes
Sep 20, 2026
robUx4
left a comment
robUx4
left a comment
Contributor
There was a problem hiding this comment.
Looks Good To Me.
Not that this Pull Request is for the master branch which builds libebml v2. For the stable libebml v1 we will need a Pull Request for the 1.x branch.
Contributor
|
I did the backport in #359 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FreeBSD and OpenBSD package managers do not build utf8cpp, honoring the upstream installation instructions, so the use of find package fails as these distributions do not ship the cmake files. To fix these distros use find_path to find the include dir.
Ref: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=298368
See also nemtrif/utfcpp#142