Repository navigation
Conversation
- Upgrade zmenu-api to 1.1.2.1 and remove the local zMenu JAR and Gradle file dependencies. - Use InventoryManager serialization for mailbox items, vault contents and icons, and item holograms. - Create standard sounds through the API and preserve custom resource-pack sounds through SoundOption. - Update the changelog and remove the local library JAR ignore exception.
- Document item deserialization through the registered zMenu service and its minimum version. - Clarify custom sound playback, nullable sound options and mailbox item results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
zEssentials still compiled against a checked-in zMenu implementation JAR for item persistence and sound creation. Upgrade
zmenu-apito 1.1.2.1 and use the published API for these remaining integrations, removing the binary from the repository and simplifying dependency maintenance.libs/zMenu-1.1.2.0.jar, its Gradle file dependencies and the local-library JAR ignore exception.InventoryManager#serializeItemStackanddeserializeItemStackfor mailbox items, vault contents and icons, and item holograms. Existing constructors and the stored item format are preserved.InventoryManager#createSoundOptionfor teleportation and chat ping sounds. Preserve resource-pack sounds with a smallSoundOptionimplementation that plays their string keys through Paper: the zMenu factory currently returnsnullfor names it cannot resolve.Validation
Runtime checks used local Paper servers and simulated players for sound playback; audible in-game verification remains to be done.