Repository navigation
Matroska: hash of the output file from the current data after a remap - #502
Merged
Merged
Conversation
The hash of the output file kept the address of the file data at the beginning of the parsing. A remap maps the file at another address and releases the previous map when no frame uses it any more, so the hash read unmapped memory: random crash at the end of --all (e.g. 1000 HD DPX frames encoded with ffv1_vulkan, 4 crashes in 5 runs), not specific to a slice count. The hash now uses the current data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hash of the output file kept the address of the file data at the beginning of the parsing. A remap maps the file at another address and releases the previous map when no frame uses it any more, so the hash read unmapped memory. The hash now uses the current data.