Repository navigation
Transform: any slice count with blocks of several pixels - #503
Merged
Merged
Conversation
DPX with blocks of several pixels and v210: a 32-bit word with the data of pixels of several slices is written by one slice, the other slices put their part of the word in their slot, merged when all slices are decoded. - RGB and Y 12-bit packed, Y 10-bit filled: the slot index is the slice index (wrong index with narrow slices, e.g. 600 pixels and 32 slices, or 1 pixel per slice), the merge is done for all frames (it was skipped if the first slice had no block in 2 slices) and only for slice ends inside a block (Y 10-bit merged slots not written). - RGBA 10-bit filled and RGBA 12-bit packed: slice beginning or ending inside a block, it was not supported. - v210: same with up to 2 words per slot, the chroma of a slice being from x / 2 with ceil(w / 2) samples (a chroma pair split by an odd slice boundary, e.g. FFmpeg software encoder with 720 pixels and 16 horizontal slices, is in both slices), it was not supported. A plane is reused only with the same line slice count (slots indexed by slice), or by a decoder with 1 slice. The slice count is no longer reduced for RGBA 10-bit, RGBA 12-bit packed and v210 (e.g. 144 slices instead of 64 for 2048-pixel RGBA 12-bit), lines ending inside a block are still rejected for them. Checked with the internal decoder: DPX block flavors and v210 encoded with -slices 1 to 1024 and ffv1_vulkan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DPX with blocks of several pixels and v210: a 32-bit word with the data of pixels of several slices is written by one slice, the other slices put their part of the word in their slot, merged when all slices are decoded.
The slice count is no longer reduced for RGBA 10-bit, RGBA 12-bit packed and v210 (e.g. 144 slices instead of 64 for 2048-pixel RGBA 12-bit), lines ending inside a block are still rejected for them. Checked with the internal decoder: DPX block flavors and v210 encoded with -slices 1 to 1024 and ffv1_vulkan.