fix(AssetsController): remove ws metadata population - #9790
Open
Prithpal-Sooriya wants to merge 9 commits into
Open
fix(AssetsController): remove ws metadata population#9790Prithpal-Sooriya wants to merge 9 commits into
Prithpal-Sooriya wants to merge 9 commits into
Conversation
this population is poisoning (invalid metadata) and skips our detection pathways
…tadata-population
Contributor
Author
|
@metamaskbot publish-preview |
…ng `assetsInfo` publication during balance updates; metadata is now sourced from the Token API. Bump dependencies for `transaction-controller`, `core-backend`, and `config-registry-controller`.
Prithpal-Sooriya
force-pushed
the
fix/remove-ws-metadata-population
branch
from
August 5, 2026 09:33
1e3d521 to
fa03cc8
Compare
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
…tadata-population
…ng by stopping `assetsInfo` publication during balance updates. Metadata is now sourced from the Token API to enhance token detection and prevent spam filtering. Bump dependencies for `@metamask/keyring-controller` and `@metamask/network-enablement-controller`.
…sk/core into fix/remove-ws-metadata-population
Contributor
Author
|
@cursor /babysit |
|
Babysit complete — CI is green again. What failedThe Validate changelog job failed because The All jobs pass job failed as a downstream effect of that changelog failure. What I fixedMerged both entries into one ### Fixed
- Preserve pooled-staking balances across Accounts API chain-slice updates ...
- Stop publishing `assetsInfo` from websocket balance updates ...Verification
Pushed commit: PR #9790 is mergeable with no open review comments. Preview builds were already published for   |
Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
WS updates contain metadata. The intention was we can use this metadata to save on API calls.
However this metadata population is poisoning our system:
This PR removes metadata addition from WS, so all added tokens will go through our TokenAPI as source of truth and detection heuristics.
References
Mobile Integration: MetaMask/metamask-mobile#34366
Ticket: https://consensyssoftware.atlassian.net/browse/ASSETS-3844
Checklist
Note
Medium Risk
Touches real-time balance ingestion and how metadata reaches state; behavior change is intentional for security but may briefly delay metadata until Token API enrichment runs.
Overview
Account activity websocket updates now emit balances only —
AccountActivityDataSourceno longer mergesassetsInfofrom the WS payload or calls an injectedgetAssetTypefromAssetsController.That closes a metadata poisoning path: the payload’s
unit(on-chain symbol/name) could mark scam airdrops as “known” instate.assetsInfoand skipTokenDataSourceoccurrence/spam checks. Decimals from the WS payload are still used only to convert raw amounts to human-readable balances.Token names, symbols, and detection metadata are left for
TokenDataSource/ Token API in the same pipeline pass. Tests were updated accordingly (including assertingassetsInfostays undefined when the payload carries attacker-controlledunitvalues).Reviewed by Cursor Bugbot for commit f931f96. Bugbot is set up for automated code reviews on this repo. Configure here.