feat(transaction-controller): extend isSimulationEnabled to accept optional TransactionMeta argument - #9800
Draft
matthewwalsh0 wants to merge 3 commits into
Draft
feat(transaction-controller): extend isSimulationEnabled to accept optional TransactionMeta argument#9800matthewwalsh0 wants to merge 3 commits into
matthewwalsh0 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
isSimulationEnabledconstructor option onTransactionControllerpreviously had the type() => boolean, giving consumers no visibility into which transaction triggered the check. This made it impossible to implement per-transaction simulation policies (e.g. skip simulation for certain transaction types, origins, or chain IDs).This change updates the callback signature to
(transactionMeta?: TransactionMeta) => boolean. The argument is optional so the change is backward-compatible — existing consumers that pass() => booleancontinue to compile without modification. All three call sites that have aTransactionMetain scope (#updateTransactionInternal,#updateSimulationData,#updateGasEstimate) now forward the meta; the two remaining call sites (estimateGas,estimateGasBuffered) and the batch utility pass no argument, which is valid given the optional typing.The matching
isSimulationEnabledmember ofAddTransactionBatchRequestinbatch.tsis updated to the same signature.References
Checklist