fix(perps-controller): show chart by default on first Pro mode switch - #9920
Open
michalconsensys wants to merge 3 commits into
Open
fix(perps-controller): show chart by default on first Pro mode switch#9920michalconsensys wants to merge 3 commits into
michalconsensys wants to merge 3 commits into
Conversation
Expand the Pro chart the first time a user enters Pro mode, then keep their last chart visibility preference on later Lite/Pro switches.
Remove the hasEnteredProMode state and setPerpsMode chart expansion so Pro chart visibility is controlled only by the layout default.
Set DEFAULT_PRO_LAYOUT_PREFERENCES.chartExpanded to true so first-time Pro users see the chart; persisted hidden preferences still win.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Switching from Perps Lite to Pro remembered the last chart visibility setting, but the first switch into Pro used
chartExpanded: false. That hid the chart by default and made it easy for users to miss that a chart existed.This change expands the chart the first time a user enters Pro mode via
setPerpsMode, then keeps their lastchartExpandedpreference on later Lite/Pro switches.Implementation notes:
hasEnteredProMode(defaultfalse) to distinguish first Pro entry from later visits.modefield (from a version that already supported Pro mode) is treated as a returning user so an existing hidden-chart preference is not overwritten after upgrade.DEFAULT_PRO_LAYOUT_PREFERENCES.chartExpandedstaysfalse; the first-entry override lives insetPerpsModerather than changing the static default.References
Checklist
Note
Cursor Bugbot is generating a summary for commit 1d909c6. Configure here.