Repository navigation
Conversation
- ConnectionMixin: re-apply the tick-end fix for 'Invalid move player packet received' kicks (from the update-26.3 branch) - TitleScreenMixin: guard against null Config during early title screen rendering - SodiumDefaultFluidRendererMixin: fix VerifyError with Sodium 0.9.2 by no longer capturing the removed otherState local variable and targeting the new isFluidSideExposed signature
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Fixes three crashes on MC 26.3:
Invalid move player packet receivedkicks (bug when I try to hit a player (26.3) #6733) — the server now rejects multiple position packets within a single client tick, soServerboundClientTickEndPacketis re-inserted as needed. Without this, using modules such as Criticals (packet-based attack) gets the player kicked.Configduring early title screen rendering — since MC 26.3, the first frame is extracted duringMinecraft.<init>, before Meteor finishes initialization, causing an NPE crash at startup.java.lang.VerifyError: Bad local variable typewith Sodiummc26.3-0.9.2— theotherStatelocal variable was removed upstream, so capturing it via@Localproduced invalid bytecode. The neighbor state is now derived fromBlockGetterdirectly, and the injection targets the new 5-paramisFluidSideExposedsignature.Related issues
How Has This Been Tested?
VerifyError, Xray fluid rendering worksInvalid move player packet receivedkickChecklist: