Repository navigation
fix(SwingMode): follow 26.3 swing animation and packet rules - #6740
Merged
Big-Iron-Cheems merged 1 commit intoOct 20, 2026
Merged
Conversation
26.3 moved the swing packet out of LocalPlayer.swing into the attack paths: interaction swings are predicted locally and broadcast by the server from its own interaction result, while attacks still need `ServerboundPunchPacket`. SwingMode now exposes attackSwing (attack animation + packet) and interactSwing (interact animation, never a packet), with `of(boolean)` as an adapter for the existing boolean call sites. Every call site is reclassified, which also fixes the wrong animation on interaction and block-breaking paths, spurious punch packets after interactions, swing checks that accepted `Fail`/`SERVER_ONLY` results, and attack swings that stopped notifying the server after the 26.3 migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
26.3 moved the swing packet out of LocalPlayer.swing into the attack paths: interaction swings are predicted locally and broadcast by the server from its own interaction result, while attacks still need
ServerboundPunchPacket.SwingMode now exposes attackSwing (attack animation + packet) and interactSwing (interact animation, never a packet), with
of(boolean)as an adapter for the existing boolean call sites. Every call site is reclassified, which also fixes the wrong animation on interaction and block-breaking paths, spurious punch packets after interactions, swing checks that acceptedFail/SERVER_ONLYresults, and attack swings that stopped notifying the server after the 26.3 migration.Related issues
No issue yet
How Has This Been Tested?
//
Checklist: