Repository navigation
Split projects.osl into one file per concern - #70
Merged
Merged
Conversation
projects.osl was 3,962 lines covering access checks, responses, quotas, create, chunked uploads, upload and history, storage snapshots, reads, vanity URLs, update, trash, publishing, discovery and remixes. Each is now its own file in src/projects, and every file's export block lists only the names it defines that other directories use. This is a pure move: every non-blank line is unchanged, sibling files share private names as before, the route dump is identical, tests pass and the offline smoke run matches the previous build.
Mistium
force-pushed
the
split-projects
branch
from
November 1, 2026 07:17
257511f to
675546c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #69.
src/projects/projects.oslwas 3,962 lines. It's now one file per concern:project-access.oslcanEditProject,canViewProject, view keys, private-only rulesproject-response.oslproject-quota.oslproject-create.oslupload-parts.oslproject-upload.oslproject-snapshots.oslproject-read.oslproject-vanity.oslproject-update.oslproject-trash.oslproject-publishing.oslproject-discovery.oslproject-remix.oslIt's a pure move. Every non-blank line is unchanged, checked by comparing the line sets before and after. Sibling files in a directory share private names, so nothing new is exported. Each file's export block lists only the names it defines that other directories use. Caches and constants moved with the code that uses them. A second commit fixes the indentation of one line that sat at column 0 inside a function.
Next.
handleUploadProjectLocked(about 565 lines) andhandleUpdateProjectLocked(about 490) are still single functions. They're the next step, together with record types andresulterrors once osl/.go#51 is available.Checks:
osl lsp check main.oslreports no diagnostics, andosl testpasses 45/45.osl compilebuilds.scripts/e2e_smoke.py) returns responses matching the previous build across all 29 steps.There is no visible change.