Skip to content

fix: skip empty expiration reschedules - #2027

Merged
crossle merged 1 commit into
mainfrom
fix/avoid-empty-expiration-reschedule
Aug 13, 2026
Merged

fix: skip empty expiration reschedules#2027
crossle merged 1 commit into
mainfrom
fix/avoid-empty-expiration-reschedule

Conversation

@YeungKC

@YeungKC YeungKC commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • notify the expiration scheduler only when marking a read message changes a persisted expiration deadline
  • cover normal-message reads without an expiration reschedule

Testing

  • flutter test test/db/expired_message_dao_test.dart
  • dart analyze --fatal-infos lib/db/dao/expired_message_dao.dart test/db/expired_message_dao_test.dart

@YeungKC
YeungKC requested a review from crossle August 13, 2026 09:07
@crossle
crossle merged commit 2a3e355 into main Aug 13, 2026
3 checks passed
@crossle
crossle deleted the fix/avoid-empty-expiration-reschedule branch August 13, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants