Skip to content

fix(frontend): update sidebar account menu and hover navigation - #4095

Merged
jeffwu-1999 merged 7 commits into
developfrom
bugfix_hzw_261014
Oct 15, 2026
Merged

jeffwu-1999 merged 7 commits into
developfrom
bugfix_hzw_261014

Conversation

@hzwllm

@hzwllm hzwllm commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Functional changes

  • Removed the shared top and bottom bars. Moved version information, GitHub, ModelEngine, terms, copyright, and the eligible monitoring link into the sidebar account menu.
  • Updated account menu dimensions, spacing, and colors while retaining the existing font family. Added a language submenu with the current language marked; appearance settings were not added.
  • Changed the collapsed sidebar to show icons only. Hovering expands it from 64px to 240px, overlaying the content without shifting the page.
  • Aligned icons and labels horizontally, including the logo and product name. Long labels are truncated and display their full text on hover.
  • Kept the sidebar expanded while account or notification popups are open. Added delayed collapse to prevent accidental closing during interaction.
  • Fixed unsolicited /users requests by disabling profile link prefetch and using the localized route. Explicit click navigation remains available.
  • Preserved existing permissions, visibility rules, authentication actions, and logout confirmation. No backend changes were made.
    Test coverage
  • 35 frontend unit tests passed, covering hover expansion, delayed collapse, re-entry, keyboard focus, popup handling, timer cleanup, account states, link visibility, language switching, logout confirmation, and monitoring access.
  • 4 formal D1 tests passed, covering menu permissions, authentication states, routing, and Chinese/English menu ordering.
  • Formal D4 browser regression passed, covering actual dimensions, unchanged content position, horizontal alignment, truncation tooltips, popup behavior, language switching, and narrow-screen boundaries.
  • Before the fix, the request regression detected 4 unsolicited profile requests. After the fix, three account popup open/close cycles produced 0 profile requests, while clicking the profile link navigated successfully.
  • TypeScript checks, scoped ESLint and Prettier checks, formal test asset validation, and the production image build passed.
image

@jeffwu-1999
jeffwu-1999 merged commit 5c627f5 into develop Oct 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants